java - Make app more effecient by eliminating extra codes -

-

i have following code starts a way z :

if (someid.matches("a") || someid.matches("a")) {     tvletcap.settext("a");     tvletlow.settext("a");     ivlettericon.setimageresource(r.drawable.apple);     btndisplayword.settext("a apple");     btnplay.setonclicklistener(new view.onclicklistener() {         public void onclick(view v) {             stopplaying();             mpsound = mediaplayer.create(myclass.this, r.raw.a);             mpsound.setlooping(false);             mpsound.start();             btnplay.setvisibility(view.gone);             btnstop.setvisibility(view.visible);             btnstop.setonclicklistener(stopsound);             mpsound.setoncompletionlistener(new oncompletionlistener() {                 @override                 public void oncompletion(mediaplayer mp) {                     btnplay.setvisibility(view.visible);                     btnstop.setvisibility(view.gone);                 }             });         }     }); }        if (someid.matches("b") || someid.matches("b")) {     tvletcap.settext("b");     tvletlow.settext("b");     ivlettericon.setimageresource(r.drawable.ball);     btndisplayword.settext("b ball");     btnplay.setonclicklistener(new view.onclicklistener() {         public void onclick(view v) {                 stopplaying();                 mpsound = mediaplayer.create(myclass.this, r.raw.b);             mpsound.setlooping(false);                 mpsound.start();             btnplay.setvisibility(view.gone);             btnstop.setvisibility(view.visible);             btnstop.setonclicklistener(stopsound);             mpsound.setoncompletionlistener(new oncompletionlistener() {                 @override                 public void oncompletion(mediaplayer mp) {                     btnplay.setvisibility(view.visible);                     btnstop.setvisibility(view.gone);                 }             });         }     }); }

would work oppose above:

switch(someid) {     case a:         setletter("a");         addicon("apple");         break;     case b:         setletter("b");         addicon("ball");         break;     default:         break; }  public void setletter(string strletter) {     tvletcap.settext(strletter);     tvletlow.settext(strletter.tolowercase()); } public void addicon(string iconletter) {     ivlettericon.setimageresource(r.drawable. + iconletter);     btndisplayword.settext(iconletter.charat(0).touppercase() + " " + iconletter.touppercase()); }

i guessing issue might line , how fix it?:

ivlettericon.setimageresource(r.drawable. + iconletter);

also possible take entire btnplay function different function , pass letter did other functions it's not repeated over?

simplest solution: add parameter addicon:

public void addicon(string iconletter, int iconresource){     ivlettericon.setimageresource(iconresource);     btndisplayword.settext(iconletter.charat(0).touppercase() + " " + iconletter.touppercase()); }

then call with

seticon("apple", r.drawable.apple);

as far reusing on click listener, it's possible. have single onclick listener that's listening views. when view clicked, it's passed in argument onclick(view view) method. can use find start/stop button view , whatever them. also, there's useful (and abused) method pair: settag(object object), , gettag(). might want using store resource id raw audio file want play when button clicked.


Comments

Post a Comment

Popular posts from this blog

java - Run a .jar on Heroku -

-
i trying run .jar file on heroku, , can't find instructions anywhere on how this. have read wants me compile uploading heroku. possible, , if is, how this? if helps, trying run minecraft craftbukkit server, , don't have pom.xml file yet. you didn't provide details i'll try give , people reaches question way it. first of all, create heroku account , create heroku application (assumed have done that). second, need generate application jar , upload heroku. so, open terminal , install heroku cli (assuming unix terminal): $ sudo npm install -g heroku-cli you need have npm , nodejs installed, can check link: https://www.digitalocean.com/community/tutorials/how-to-install-node-js-on-ubuntu-16-04 once done that, can use npm update node version acceptable heroku-cli: $ sudo npm install -g n $ sudo n 7.10.0 and run: $ sudo npm install -g heroku-cli in order deploy jars, need install deploy plugin: $ sudo heroku plugins:install heroku-cli-deploy ...
Read more

java - Jtable duplicate Rows -

-
Image
when add new rows in jtable duplicate rows many times this method update jtable public final void tableaucomande(){ ((defaulttablemodel)tabcommande.getmodel()).getdatavector().clear(); session s=hibernateutil.getsessionfactory().opensession(); criteria cr1= s.createcriteria(commande.class); list <commande> lcs=cr1.list() ; criteria cr2= s.createcriteria(lignecommande.class); list <lignecommande> lck=cr2.list() ; if(lcs.size()!=0 && lck.size()!=0) { (commande lc:lcs) { for(lignecommande lig:lck){ ((defaulttablemodel)tabcommande.getmodel()).addrow(new object[]{ lc.getid_cmd(),lc.getnumcmd(),lc.getdate_cmd(),lc.getclient().getnomprenom(), lig.getproduit().getlib_prd(),lig.getquantite(),lig.getproduit().getid_prd() }); } } // tabcommande.setrowselectioninterval(tabcommande.getrowcount()-1,tabcommande.getrowcount()-1); } } this code add add data rows displaye...
Read more

validation - How to pass paramaters like unix into windows batch file -

-
i need pass various parameters .cmd file unix format file.cmd -configuration=value -source=value -flag but, try this: startlocal @echo off cls setlocal set cmdline=%* set configuration= set source= set badargs= set validation= goto main :splitargs echo splitargs(%*) if "%*" neq "" ( /f "tokens=1,2,* delims== " %%i in ("%*") call :assignkeyvalue %%i %%j & call :splitargs %%k ) goto :eof :assignkeyvalue echo assignkeyvalue(%1, %2) if /i %1==-configuration ( set configuration=%2 ) else if /i %1==-source ( set source=%2 ) else ( rem append unrecognised [key,value] badargs echo unknown key %1 set badargs=%badargs%[%1, %2] ) goto :eof :validate echo validating set validation=fail if defined configuration ( echo -configuration ok if defined source ( echo -source ok if not defined badargs ( set validation=success ) ) ) goto :eof :main cl...
Read more