ruby on rails - How to test a random uniq values with rspec -

-

i have code:

def self.generate_random_uniq_code   code = sprintf("%06d", securerandom.random_number(999999))   code = self.generate_random_uniq_code if self.where(code: code).count > 0   code end

the goal create random codes new register, code can't exist in registers i'm trying test way, when mock securerandom return same value:

it "code unique"   old_code = code.new   old_code.code = 111111   new_code = code.new   expect(securerandom).to receive(:random_number) {old_code.code}   new_code.code = code.generate_random_uniq_code   expect(new_code.code).to_not eq old_code.code end

i trying find if there way enable , disable mock behavior, not find it, i'm not sure i'm doing test right way, code seems no work fine me. welcome, thanks!

tl;dr

generally, unless testing prng wrote, you're testing wrong behavior. consider behavior you're trying test, , examine alternatives. in addition, six-digit number doesn't have enough of key space ensure real randomness purposes, may want consider more robust.

some alternatives

one should test behavior, rather implementation. here alternatives consider:

  1. use uuid instead of six-digit number. uuid statistically less likely encounter collisions current solution.
  2. enforce uniqueness in database column adjusting schema.
  3. using rails uniqueness validator in model.
  4. use factorygirl sequences or lambdas return values test.

fix spec

if insist on testing piece of code, should @ least use correct expectations. example:

# won't useful, if runs. expect(new_code.code).to_not  old_code.code

instead, should check equality, this:

old_code = 111111 new_code = code.generate_random_uniq_code new_code.should_not eq old_code

your code may broken in other ways (e.g. code variable in method doesn't seem instance or class variable) won't guarantee above work, should @ least point in right direction.


Comments

Post a Comment

Popular posts from this blog

java - Run a .jar on Heroku -

-
i trying run .jar file on heroku, , can't find instructions anywhere on how this. have read wants me compile uploading heroku. possible, , if is, how this? if helps, trying run minecraft craftbukkit server, , don't have pom.xml file yet. you didn't provide details i'll try give , people reaches question way it. first of all, create heroku account , create heroku application (assumed have done that). second, need generate application jar , upload heroku. so, open terminal , install heroku cli (assuming unix terminal): $ sudo npm install -g heroku-cli you need have npm , nodejs installed, can check link: https://www.digitalocean.com/community/tutorials/how-to-install-node-js-on-ubuntu-16-04 once done that, can use npm update node version acceptable heroku-cli: $ sudo npm install -g n $ sudo n 7.10.0 and run: $ sudo npm install -g heroku-cli in order deploy jars, need install deploy plugin: $ sudo heroku plugins:install heroku-cli-deploy ...
Read more

java - Jtable duplicate Rows -

-
Image
when add new rows in jtable duplicate rows many times this method update jtable public final void tableaucomande(){ ((defaulttablemodel)tabcommande.getmodel()).getdatavector().clear(); session s=hibernateutil.getsessionfactory().opensession(); criteria cr1= s.createcriteria(commande.class); list <commande> lcs=cr1.list() ; criteria cr2= s.createcriteria(lignecommande.class); list <lignecommande> lck=cr2.list() ; if(lcs.size()!=0 && lck.size()!=0) { (commande lc:lcs) { for(lignecommande lig:lck){ ((defaulttablemodel)tabcommande.getmodel()).addrow(new object[]{ lc.getid_cmd(),lc.getnumcmd(),lc.getdate_cmd(),lc.getclient().getnomprenom(), lig.getproduit().getlib_prd(),lig.getquantite(),lig.getproduit().getid_prd() }); } } // tabcommande.setrowselectioninterval(tabcommande.getrowcount()-1,tabcommande.getrowcount()-1); } } this code add add data rows displaye...
Read more

validation - How to pass paramaters like unix into windows batch file -

-
i need pass various parameters .cmd file unix format file.cmd -configuration=value -source=value -flag but, try this: startlocal @echo off cls setlocal set cmdline=%* set configuration= set source= set badargs= set validation= goto main :splitargs echo splitargs(%*) if "%*" neq "" ( /f "tokens=1,2,* delims== " %%i in ("%*") call :assignkeyvalue %%i %%j & call :splitargs %%k ) goto :eof :assignkeyvalue echo assignkeyvalue(%1, %2) if /i %1==-configuration ( set configuration=%2 ) else if /i %1==-source ( set source=%2 ) else ( rem append unrecognised [key,value] badargs echo unknown key %1 set badargs=%badargs%[%1, %2] ) goto :eof :validate echo validating set validation=fail if defined configuration ( echo -configuration ok if defined source ( echo -source ok if not defined badargs ( set validation=success ) ) ) goto :eof :main cl...
Read more